Consistency Check for Indexed Outputs (e.g., Shell_Slices, Meridional_Slices) #574
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements some consistency/sanity checks when Rayleigh interprets the values of variables such as shellslice_levels, meridional_indices etc. Previously, Rayleigh would accept values that fell outside of the grid bounds, which could lead to crashes. With this addition, indicial values that fall outside of the grid bounds are filtered out. If unallowed values are specified for the normalized indices (e.g., shell_slice_levels_nrm), those should also be filtered out by these modifications to the code logic.
This addresses the cause of the 2nd crash reported in issue #570.