Modified Configuration File #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gassmoeller
reviewed
Jun 19, 2024
configure
Outdated
Comment on lines
857
to
859
| STD_FLAGS="-lc++" | ||
| else | ||
| STD_FLAGS="" | ||
| STD_FLAGS="-lstdc++" |
There was a problem hiding this comment.
Did you add the STD_FLAGS back in on purpose?
There was a problem hiding this comment.
I did not, not sure why those appeared back up. Will change that
|
The testers dont like it: https://github.com/geodynamics/Rayleigh/actions/runs/9586908067/job/26435825639?pr=535 |
BrandonJLazard
force-pushed
the
add_configurechecks
branch
from
3f6eca2 to
9f30ce8
Compare
gassmoeller
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added conditionals so that the user has the correct compiler and libraries configured before the actual configuration is run.