Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Shell_Avgs to Enable Time-averaging and concatenation #499

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

feathern
Copy link
Contributor

This PR modifies the Shell_Avgs class so that it also accepts a list of multiple Shell_Avgs files. That data can either be concatenated or time-averaged as described in docstring. In addition, the class now contains an output method so that the current Shell_Avgs object structure can be saved to a new Shell_Avgs file.

Some notes:

  1. Single files can still be read as they always have been.
  2. This is a lot of new code. I've been using this new version of the Shell_Avgs class for a couple of years now. When doing a review, the most straightforward path is probably to test out the concatenation and time-averaging functionality.

Copy link
Contributor

@illorenzo7 illorenzo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Nick!

@illorenzo7 illorenzo7 merged commit 456aa34 into geodynamics:main Apr 3, 2024
7 checks passed
@feathern feathern deleted the Shell_Avgs branch May 10, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants