Fill out more of EnhacnedGameObject's Class members and other missing… #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I swear the verification system is screwed up. |
altalk23
reviewed
Nov 27, 2024
bindings/2.2074/GeometryDash.bro
Outdated
| bool m_activatedByPlayer1; | ||
| bool m_activatedByPlayer2; | ||
| bool m_hasUniqueCoin; | ||
| cocos2d::CCColor3B m_unkAnimationColor; |
There was a problem hiding this comment.
this is supposed to be ccColor3B not uppercase
altalk23
reviewed
Nov 28, 2024
|
wow github is weird |
altalk23
reviewed
Nov 28, 2024
| @@ -4770,8 +4770,19 @@ class EnhancedGameObject : GameObject { | |||
| void updateUserCoin() = win 0x1a3970, imac 0x5a9770, m1 0x4e3b94; | |||
| TodoReturn waitForAnimationTrigger(); | |||
|
|
|||
| PAD = android32 0x25, win 0x2a, android64 0x22, mac 0x22; | |||
|
|
|||
| bool m_poweredOn; | |||
There was a problem hiding this comment.
this ones a weird one because android32 becomes 0x26 but others are fine, maybe the old pad was wrong
bindings/2.2074/GeometryDash.bro
Outdated
| bool m_activatedByPlayer1; | ||
| bool m_activatedByPlayer2; | ||
| bool m_hasUniqueCoin; | ||
| cocos2d::ccColor3B m_unkAnimationColor; |
There was a problem hiding this comment.
I'm not so sure about the validity of this as first member of effectgameobject is also cccolor3b (and pads dont match)
member tests could be helpful
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this pull request is better than yesterday's one where I was up at 2AM. Seems having GameObject's previous class members helped out but I am still hunting down the remaining ones that slipped through the cracks somehow thanks to this update.