fix parameters bigger than 4 bytes being passed through registers

geode-sdk · Mar 18, 2024 · 7fa328b · 7fa328b
1 parent a46fb9e
commit 7fa328b
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/convention/WindowsConvention.cpp b/src/convention/WindowsConvention.cpp
@@ -225,12 +225,12 @@ class PushParameters final {
 		size_t index = 0;
 		for (auto& [oindex, param] : reordered) {
 			// first primitive through ecx
-			if (registersUsed == 0 && param.m_kind == AbstractTypeKind::Primitive) {
+			if (registersUsed == 0 && param.m_kind == AbstractTypeKind::Primitive && param.m_size <= sizeof(void*)) {
 				res.push(param, Register::ECX, oindex);
 				registersUsed = 1;
 			}
 			// second primitive through edx
-			else if (registersUsed == 1 && param.m_kind == AbstractTypeKind::Primitive) {
+			else if (registersUsed == 1 && param.m_kind == AbstractTypeKind::Primitive && param.m_size <= sizeof(void*)) {
 				res.push(param, Register::EDX, oindex);
 				registersUsed = 2;
 			}
@@ -283,7 +283,7 @@ class PushParameters final {
 		size_t index = 0;
 		for (auto& [oindex, param] : reordered) {
 			// first primitive through ecx
-			if (registersUsed == 0 && param.m_kind == AbstractTypeKind::Primitive) {
+			if (registersUsed == 0 && param.m_kind == AbstractTypeKind::Primitive && param.m_size <= sizeof(void*)) {
 				res.push(param, Register::ECX, oindex);
 				registersUsed = 1;
 			}