Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a safe version of parsing broma files so that the code doesn't have to exit #7

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

CallocGD
Copy link

@CallocGD CallocGD commented Dec 8, 2024

This is a problem with pybroma where the script will exit when it shouldn't when handling lets just say multiple at a time and I am planning to make a discord bot that can summarize the geode bindings and other important elements and with a rust port on the way getting this in here felt like a must for me as the std::exit(1) part of this code infuriates me greatly as it's just not proper error handling if that makes any sense to anybody. I feel like error handling should be customized rather than simply exiting. when something is wrong, This was my attempt at writing a solution I had another idea to use a something similar to a std::pair for handling the result if required incase this pull request gets rejected.

@CallocGD
Copy link
Author

CallocGD commented Dec 8, 2024

Nevermind I think I just made it better Gonna do a few more tweaks

@CallocGD
Copy link
Author

CallocGD commented Dec 8, 2024

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant