New Release v1.31.0 - #minor #947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
identify request already provides us with all what we need (feature data), the only thing missing is the HTML popup. This means getFeature request is now only called when the app is loaded with pre-selected features. This reduces the number of calls to our backend for an identify on the map (should be a bit faster)
they are required for some layer, as the result of these endpoints can vary depending on the map resolution.
…quests PB-669 : separate html popup request from getFeature
looping on sub-layers and bunching together any fulfilled getFeatureInfo requests.
…_group_of_layers PB-681 : add support for group of external layers getFeatureInfo
Try to make the code cleaner, more robust and easier to understand (not sure I achieved this though). One major changes is that for the "all" hack, now in the url we don't use anymore @year=9999 but @year=all (legacy timestamp with 9999 are still working and are translated to @year=all) Also added support for @year=none when a layer as no data for timeslider preview year. I also tried to document the layer attributes and all special cases I also created a ticket PB-680 to do more clean up concerning the "all" hack in future.
Now the layer timestamp to use is always set to the layer config so there is no need to look at the preview year of the time slider down the way. This simplify the code. Note the preview year is still used as URL param to create permalink with timeslider activated at a particular year.
In legacy link no timestamp is an empty string which should result of using the default layer timestamp, because in javavascript `&& ''` is true, the previous code resulted in a @year=none
In this case we don't want to provide the time selector button
Also split a test into 2 it(), somehow it strangely failed when done in one go while when manually testing it worked. I could not understand exactly why. It seems its related to a timing issue with the dispatching of the @year and timeSlider parameter.
Also fixing typos
Before when the timeSlider was active and we added a layer, the new layer did not set its current year to the time slider year until the slider changed. Also reduced the number of dispatch by only dispatching the set year to layer that don't have yet the correct year.
PB-675: Clean up TimeSlider code
Passing run #2710 ↗︎
Details:
Review all test suite changes for PR #947 ↗︎ |
|||||||||||||||
ltkum
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test link