Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PB-199: add new point on an existing line #1129

Merged
merged 29 commits into from
Nov 21, 2024
Merged

PB-199: add new point on an existing line #1129

merged 29 commits into from
Nov 21, 2024

Conversation

ismailsunni
Copy link
Contributor

@ismailsunni ismailsunni commented Nov 18, 2024 •
edited
Loading

Some todos:

  • Update style when extending the line
  • Make the add vertex button smaller
  • Put the buttons so that it's not covering the line (i.e. use azimuth?)
  • Check if it's work measurement line (not showing the buttons)
  • Replace the old feature, instead adding a new one

Test link

@cypress Cypress
Copy link

cypress bot commented Nov 18, 2024 •
edited
Loading

web-mapviewer    Run #3889

Run Properties:  status check passed Passed #3889  •  git commit d07f8854e8: PB-199: Make sure that the add vertex button does not covering measurement label...
Project web-mapviewer
Branch Review pb-199-add-new-point
Run status status check passed Passed #3889
Run duration 04m 13s
Commit git commit d07f8854e8: PB-199: Make sure that the add vertex button does not covering measurement label...
Committer Ismail Sunni
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 21
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 212
View all changes introduced in this branch ↗︎

@ismailsunni ismailsunni changed the title Pb 199 add new point PB-199: add new point on an existing line Nov 20, 2024
@ismailsunni ismailsunni marked this pull request as ready for review November 20, 2024 09:01
pakb
pakb reviewed Nov 21, 2024
View reviewed changes
src/modules/drawing/components/AddVertexButton.vue Outdated Show resolved Hide resolved
src/modules/drawing/DrawingModule.vue Outdated Show resolved Hide resolved
src/modules/drawing/DrawingModule.vue Outdated Show resolved Hide resolved
src/modules/drawing/components/AddVertexButton.vue Outdated Show resolved Hide resolved
src/modules/drawing/components/AddVertexButton.vue Outdated Show resolved Hide resolved
src/modules/drawing/components/AddVertexButtonOverlay.vue Outdated Show resolved Hide resolved
src/modules/drawing/components/AddVertexButtonOverlay.vue Outdated Show resolved Hide resolved
src/modules/drawing/components/AddVertexButtonOverlay.vue Outdated Show resolved Hide resolved
src/modules/drawing/components/useModifyInteraction.composable.js Outdated Show resolved Hide resolved
src/modules/drawing/components/useModifyInteraction.composable.js Outdated Show resolved Hide resolved
@ismailsunni
PB-199: Add new point to the line on right click.
dae9c76
@ismailsunni
PB-199: Add tooltip for right click to add new point.
3ae57c9
@ismailsunni
PB-199: Add basic buttons for adding new vertex as an overlay.
eb92d92
@ismailsunni
PB-199: Use LineString instead Feature.
8169577
@ismailsunni
PB-199: Use tippy
3a26d8d
@ismailsunni
PB-199: Implement extend line string.
7569ce2
@ismailsunni
PB-199: Continue the line from start or end vertex.
5241b63
@ismailsunni
PB-199: Only show add vertex button while selecting line but not when…
c2f9ed9 
… editing.
@ismailsunni
PB-199: Remove unused code from the previous approach.
ba277ad
@ismailsunni
PB-199: Use proper tooltip.
65bb604
@ismailsunni
PB-199: Add style for overlay buttons.
2994ed2
@ismailsunni
PB-199: Position add vertex button depending on the line string geome…
4f2ef78 
…try.
@ismailsunni
PB-199: Only show the add vertex button on linestring excluding measu…
8ec2467 
…rement line.
@ismailsunni
PB-199: Use different approach, putting the continue drawing interact…
4239c2a 
…ion in modify interaction.
@ismailsunni
PB-199: add vertex from the starting point.
48206c3
@ismailsunni
PB-199: Remove old approach.
96c5186
@ismailsunni
PB-199: Add edit mode for better handling the add vertex buttons.
101fb7b
@ismailsunni
PB-199: Update store selected feature to update the add vertex button…
96a8856 
… position.
@ismailsunni
PB-199: Remove unused comment.
87dd1ed
@ismailsunni
PB-199: remove last point with right click on extend line mode.
13d820d
@ismailsunni
PB-199: Remove last point on right click on modify mode.
b9e9d1f
pakb
pakb reviewed Nov 21, 2024
View reviewed changes
Copy link
Contributor

@pakb pakb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as said on Slack, we should try to keep the geometry coordinates in order, even if we reverse edit (add something at the beginning)

@pakb pakb merged commit 86da74d into develop Nov 21, 2024
6 checks passed
@pakb pakb deleted the pb-199-add-new-point branch November 21, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pakb pakb pakb approved these changes

@ltkum ltkum Awaiting requested review from ltkum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ismailsunni @pakb