PB-1131: add warning when loading http resource #1123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
fix-PB-1131-add-warning-when-loading-http-resource
|
| Run status |
|
| Run duration | 04m 38s |
| Commit |
|
| Committer | Martin Künzi |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
21
|
Skipped
|
0
|
Passing
|
212
|
| View all changes introduced in this branch ↗︎ | |
sommerfe
reviewed
Nov 8, 2024
src/modules/menu/components/advancedTools/ImportFile/ImportFileOnlineTab.vue
Outdated
Show resolved
Hide resolved
ismailsunni
reviewed
Nov 11, 2024
src/modules/menu/components/advancedTools/ImportFile/ImportFileOnlineTab.vue
Outdated
Show resolved
Hide resolved
ltkum
force-pushed
the
fix-PB-1131-add-warning-when-loading-http-resource
branch
from
0574b2d
to
6c988bf
Compare
sommerfe
approved these changes
Nov 12, 2024
pakb
reviewed
Nov 12, 2024
Issue: When importing an external layer through an http source, we didn't give a warning to the user. Fix: If the resource can be loaded, and the scheme is only http, we give a warning so the user know he should use https resources.
- adding a dispatcher to the warning message dispatch - removing unused translation params - changing regex to only look at the first instance of http(s) to see if this is a http resource.
ltkum
force-pushed
the
fix-PB-1131-add-warning-when-loading-http-resource
branch
from
6c988bf
to
6d7f777
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: When importing an external layer through an http source, we didn't give a warning to the user.
Fix: If the resource can be loaded, and the scheme is only http, we give a warning so the user know he should use https resources.
Test link