PB-737: Fix CORS issues when working on localhost #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous PR #66 was too restrictive has it blocked localhost on the DEV staging which is needed to develop the web-mapviewer. The main issue was that the ALLOWED_DOMAINS config was used for CORS and for URL parameter check, but in the code the logic to validate CORS and url parameter differ, due to this it was not possible anymore to set a ALLOWED_DOMAINS value that would allow localhost as CORS and or as url parameter. The url parameter check wanted to have a regex to exactly match the host name without the path, while CORS did check the full url. Now the code has been simplified and we use the same function/logic to test url and CORS, using the full url. Note that ORIGIN and REFERER header based on the documentation should always has the scheme http:// or https://. Referer might have a path or not. So now the ALLOWED_DOMAINS must be a pattern that match a full URL not only part of it.
pakb
approved these changes
Sep 18, 2024
Instead of given regex for the full url, only provide regex for the host part of the url. This allow to not touch the configuration on deployment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PR #66 was too restrictive has it blocked localhost on the DEV staging
which is needed to develop the web-mapviewer.
The main issue was that the ALLOWED_DOMAINS config was used for CORS and for
URL parameter check, but in the code the logic to validate CORS and url parameter
differ, due to this it was not possible anymore to set a ALLOWED_DOMAINS value
that would allow localhost as CORS and or as url parameter. The url parameter
check wanted to have a regex to exactly match the host name without the path,
while CORS did check the full url.
Now the code has been simplified and we use the same function/logic to test url
and CORS, using the full url. Note that ORIGIN and REFERER header based on the
documentation should always has the scheme http:// or https://. Referer might
have a path or not.
So now the ALLOWED_DOMAINS must be a pattern that match a full URL not only part
of it.
Together with https://github.com/geoadmin/infra-kubernetes/pull/629 it fix local development of web-mapviewer