Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PB-569 Update documentation to use docker compose #67

Merged
merged 2 commits into from
Aug 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ The redirect parameter redirect the user to the corresponding url instead if set

### Dependencies

The **Make** targets assume you have **bash**, **curl**, **tar**, **docker** and **docker-compose** installed.
The **Make** targets assume you have **bash**, **curl**, **tar**, **docker** and **docker-compose-plugin** installed.

### Setting up to work

Expand All @@ -88,7 +88,7 @@ Then, you can run the setup target to ensure you have everything needed to devel

The other service that is used (DynamoDB local) is wrapped in a docker compose. Starting DynamoDB local is done with a simple

docker-compose up
docker compose up

That's it, you're ready to work.

Expand All @@ -114,7 +114,7 @@ This command run the integration and unit tests.
For testing the locally served application with the commands below, be sure to set
ENV_FILE to .env.default and start a local DynamoDB image beforehand with:

docker-compose up &
docker compose up &
export ENV_FILE=.env.default

The following three make targets will serve the application locally:
Expand Down
1 change: 0 additions & 1 deletion docker-compose.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
version: "3.4"
services:
dynamodb-local:
command: "-jar DynamoDBLocal.jar -sharedDb"
Expand Down