Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many Many Fixes #23

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

nmccready
Copy link

I don't really know where to begin on this as many dependencies and build processes were broken internally.

Off the top of my head some of the main problems:

  • go is installed from official go downloads and prebuilt binaries (hg removed)

  • go-bindata (archived and inactive / broken) moved to go-bindata/go-bindata from jteeuwen/go-bindata

  • installation within the container was invalid with newer version of go where a src project should not be installed in $GOROOT. Instead cesium-terrain-server now gets installed in $GOPATH -> /root/go/...

  • Removed versioning files which tracked cesium version and branch version. These were too static and easy to mess up. Instead these things are looked up by git within the Makefile

  • go modules used to have better dependency integrity

  • removed many unnecessary exit 1 by adding

#!/usr/bin/env bash
set -e
set -o pipefail

@joshserrin
Copy link

Our project is running into this issue. Anyway this MR can get merged and new container published?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants