-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Many Many Fixes #23
Open
nmccready
wants to merge
20
commits into
geo-data:master
Choose a base branch
from
nmccready:nmccready/buildingAgain
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Many Many Fixes #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our project is running into this issue. Anyway this MR can get merged and new container published? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't really know where to begin on this as many dependencies and build processes were broken internally.
Off the top of my head some of the main problems:
go is installed from official go downloads and prebuilt binaries (hg removed)
go-bindata (archived and inactive / broken) moved to go-bindata/go-bindata from jteeuwen/go-bindata
installation within the container was invalid with newer version of
go
where a src project should not be installed in$GOROOT
. Insteadcesium-terrain-server
now gets installed in$GOPATH
->/root/go/...
Removed versioning files which tracked cesium version and branch version. These were too static and easy to mess up. Instead these things are looked up by
git
within theMakefile
go modules used to have better dependency integrity
removed many unnecessary
exit 1
by adding