Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added in function to get prefixes and units. Address #48, #14 #52

Closed
wants to merge 1 commit into from

Conversation

vsmalladi
Copy link
Contributor

Address issues in #48 and #14. Uses code from @mikberg

@gentooboontoo
Copy link
Owner

Fixed by #53. Thanks for the PR but I finally chose an alternative which fully separates aliases and units responsibilities, thus avoiding the multi-dimensional array for getUnits. BTW, no solution is perfect because the other one makes the use of units identifiers mandatory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants