-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Recent decision to make FEATURES=pkgdir-index-trusted is now on by default breaks eclean-invalids feature. #34
Conversation
settings = var_dbapi.settings | ||
settings.unlock() | ||
settings.features.remove("pkgdir-index-trusted") | ||
bin_dbapi = portage.binarytree(pkgdir=pkgdir, settings=settings).dbapi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can instead call bin_dbapi.bintree.populate(force_reindex=True)
here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I'll do this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, this parameter was added in gentoo/portage@c9fb98b which is not in a portage release yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, this parameter was added in gentoo/portage@c9fb98b which is not in a portage release yet.
Ah so there might be a chance that portage wont go forward with that change ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, it probably will, but the parameter can't be used unless it's supported. We can used inspect.signature to check if it's supported:
https://docs.python.org/3/library/inspect.html#inspect.signature
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, it probably will, but the parameter can't be used unless it's supported. We can used inspect.signature to check if it's supported:
https://docs.python.org/3/library/inspect.html#inspect.signature
Ah sorry for earlier that was wrong this works but I'm not so sure if you meant this e4345ee
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks!
211e68f
to
b473d02
Compare
…by default breaks eclean-invalids feature See_also: gentoo/portage@3bc7bfe Signed-off-by: Siddhanth Rathod <[email protected]>
Thank you and thank you Zac for reviewing! |
Portage recently enabled FEATURES=pkgdir-index-trusted by default which breaks the eclean-invalids feature. Force reindexing after cleaning up to fix this. See-also: gentoo/portage@3bc7bfe Bug: https://bugs.gentoo.org/889300 Bug: https://bugs.gentoo.org/900224 Signed-off-by: Siddhanth Rathod <[email protected]> Closes: gentoo#34 Signed-off-by: Sam James <[email protected]>
See_also: gentoo/portage@3bc7bfe