Skip to content

Commit

Permalink
Revert "move sanity check to a central position"
Browse files Browse the repository at this point in the history
This reverts commit 6ec8341,
which breaks updating HTTP passwords
  • Loading branch information
gekmihesg committed Mar 3, 2016
1 parent 7d58540 commit 62347f3
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/components/passmanager.js
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,6 @@ PassManager.prototype = {
},

_saveLogin: function (loginPath, login) {
LoginHelper.checkLoginValues(login);
this._pass(["insert", "-m", "-f", loginPath],
this._loginToStr(login));

Expand Down Expand Up @@ -400,6 +399,7 @@ PassManager.prototype = {
},

addLogin: function addLogin(login) {
LoginHelper.checkLoginValues(login);
if (this._isFirefoxAccount(login.hostname, login.httpRealm)) {
return this._storage_json.addLogin(login);
}
Expand Down
4 changes: 2 additions & 2 deletions src/install.rdf
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,15 @@
<em:id>[email protected]</em:id>
<em:name>pass-manager</em:name>
<em:description>Replace integrated password manager by zx2c4's pass</em:description>
<em:version>0.5.1</em:version>
<em:version>0.5.2</em:version>
<em:creator>Markus Weippert</em:creator>
<em:type>2</em:type>
<!-- Mozilla Firefox -->
<em:targetApplication>
<Description>
<em:id>{ec8030f7-c20a-464f-9b0e-13a3a9e97384}</em:id>
<em:minVersion>25.*</em:minVersion>
<em:maxVersion>44.*</em:maxVersion>
<em:maxVersion>46.*</em:maxVersion>
</Description>
</em:targetApplication>
<!-- Mozilla Thunderbird -->
Expand Down

0 comments on commit 62347f3

Please sign in to comment.