-
-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: solr listen on custom network interface #143
base: master
Are you sure you want to change the base?
Conversation
Hi @geerlingguy anything else to be done from my side to make this PR happen? |
This pr has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution! Please read this blog post to see the reasons why I mark issues as stale. |
According to https://ansible.jeffgeerling.com/ you still maintain this role so this PR could be merged. |
- solr_jetty_host == '127.0.0.1' | ||
|
||
# Create cores also when solr is listening on custom network interface. Just for solr 9.3.0 and higher. | ||
- include_tasks: cores-post93.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the requirement for a separate cores task file here? I don't think that was explicitly explained but it includes a bit of duplicate code.
This pr has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution! Please read this blog post to see the reasons why I mark issues as stale. |
solr_jetty_host
.-h
host parameter in solr create script.