Add CodeQL workflow to GitHub Actions #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esabol
force-pushed
the
add-codeql-workflow
branch
from
0d2ec76 to
a78b49e
Compare
SpamapS
approved these changes
Nov 18, 2023
| # queries: security-extended,security-and-quality | ||
|
|
||
| - name: Install dependencies | ||
| run: sudo apt-get -o Acquire::Retries=3 -y install tzdata make apt-file software-properties-common libssl-dev build-essential autotools-dev autoconf automake pkgconf libboost-all-dev gperf libevent-dev uuid-dev sphinx-doc sphinx-common libhiredis-dev gcc g++ |
There was a problem hiding this comment.
Feels like we have expressed this list in like 10 places. I'm going to open an issue to collapse this into a bash script.
This was referenced Nov 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a CodeQL workflow to the repository's GitHub Actions.
See https://codeql.github.com/ for details on CodeQL.
After merging, I think you probably need to enable it in the repository's Settings. See https://docs.github.com/en/code-security/code-scanning/enabling-code-scanning/configuring-default-setup-for-code-scanning for instructions. We need to use the "Advanced" setup because gearmand needs various prerequisites installed.
Some of the warnings seem spurious. You can disable specific warnings on specific lines of the code in the web interface. We'll probably need to do that at some point, but some of the warnings should be fixed, I feel.