Remove <tuple> dependency from std::unique_ptr
#67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any updates on this? Did you submit the patch to the mailing list that accepts these patches? |
|
There as been some discussion on the libstdc++ mailing list about this. Basically, this patch breaks ABI. J. Wakely attempted a similar change but could not measure any difference in compilation speed -- however I have not yet tested his patch on my own setup, where I suspect there will be a compilation speed benefit.
Vittorio Romeo
https://vittorioromeo.com
…________________________________
From: GameCubeGBA ***@***.***>
Sent: Thursday, August 4, 2022 6:44 PM
To: gcc-mirror/gcc ***@***.***>
Cc: Vittorio Romeo ***@***.***>; Author ***@***.***>
Subject: Re: [gcc-mirror/gcc] Remove `<tuple>` dependency from `std::unique_ptr` (PR #67)
Any updates on this? Did you submit the patch to the mailing list that accepts these patches?
—
Reply to this email directly, view it on GitHub<#67 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAHAJBLD55ALNPILRZWM2GLVXPXNZANCNFSM5ZWB3YLA>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will discuss on mailing list.