This repository has been archived by the owner on Jun 23, 2024. It is now read-only.
Add configuration option to toggle the red overlay associated with visual warning mode #110
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The red overlay that flashes on the entire screen when the visual warning appears might prove to be excessively obtrusive.
Personally, when using the visual warning and deliberately using a tool until it breaks, my eyes start to hurt from the fast red flashes.
I have added a configuration option to turn it off, so that only the item is displayed in visual mode, without the red overlay.
By default, the configuration option is turned on, to preserve backwards compatibility.
On a different note, I want to kindly inquire: are you building the project in its current state?
After forking and cloning the latest state of the branch
fabric_1_20
at the time of writing, I found it incredibly inconvenient to build the project:gradle.properties
file to specifyorg.gradle.jvmargs=-Xmx1G
, otherwise I was met with an out-of-memory error when gradle performed the remapping, within the project's setup procedure'1.3-SNAPSHOT'
to'1.5-SNAPSHOT'
to allow some remap operations1.16:3.4.5+build.95
to1.20:5.10.3
, otherwise some mixins were not properly injectedteam.reborn.energy.EnergyHolder
useteam.reborn.energy.api.EnergyStorage
, and instead ofEnergyHolder.getMaxStoredPower()
useEnergyStorage.getCapacity()
(although I haven't tested this at all, I just wanted to be able to build the project, those NBT operations might need some hammers now)9.0.0
, game crashes upon trying to open this mod's page via Mod Menu. But at least I can load into a worldSo I decided to just commit the changes related to the configuration option, hoping you will add them and then create a new release with them in it, however you may be building it, for I am unsure as to how you are building it in its current state...
Do you have all these changes as uncommitted changes?