Skip to content
This repository has been archived by the owner on Jun 23, 2024. It is now read-only.

Add configuration option to toggle the red overlay associated with visual warning mode #110

Open
wants to merge 1 commit into
base: fabric_1_20
Choose a base branch
from

Conversation

CofiPRT
Copy link

@CofiPRT CofiPRT commented Apr 25, 2024

The red overlay that flashes on the entire screen when the visual warning appears might prove to be excessively obtrusive.

Personally, when using the visual warning and deliberately using a tool until it breaks, my eyes start to hurt from the fast red flashes.

I have added a configuration option to turn it off, so that only the item is displayed in visual mode, without the red overlay.
By default, the configuration option is turned on, to preserve backwards compatibility.

On a different note, I want to kindly inquire: are you building the project in its current state?
After forking and cloning the latest state of the branch fabric_1_20 at the time of writing, I found it incredibly inconvenient to build the project:

  • I had to add a gradle.properties file to specify org.gradle.jvmargs=-Xmx1G, otherwise I was met with an out-of-memory error when gradle performed the remapping, within the project's setup procedure
  • I had to change the loom version from '1.3-SNAPSHOT' to '1.5-SNAPSHOT' to allow some remap operations
  • I had to update TechReborn from 1.16:3.4.5+build.95 to 1.20:5.10.3, otherwise some mixins were not properly injected
    • Along with this, instead of team.reborn.energy.EnergyHolder use team.reborn.energy.api.EnergyStorage, and instead of EnergyHolder.getMaxStoredPower() use EnergyStorage.getCapacity() (although I haven't tested this at all, I just wanted to be able to build the project, those NBT operations might need some hammers now)
  • I had to update Mod Menu just to be able to see the menu screen (otherwise it crashed), yet even after I updated it to 9.0.0, game crashes upon trying to open this mod's page via Mod Menu. But at least I can load into a world

So I decided to just commit the changes related to the configuration option, hoping you will add them and then create a new release with them in it, however you may be building it, for I am unsure as to how you are building it in its current state...

Do you have all these changes as uncommitted changes?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant