Skip to content
This repository has been archived by the owner on Jun 23, 2024. It is now read-only.

Hotfix for version 1.10.5 + additional config options #101

Open
wants to merge 4 commits into
base: fabric_1_20
Choose a base branch
from

Conversation

TheMrEngMan
Copy link
Contributor

@TheMrEngMan TheMrEngMan commented Sep 29, 2023

Fixes:

  • Fix cardinal-components-entity causing crash due to outdated version (Fixes crash on 1.20.2 #100)
  • Properly include cloth config as dependency
  • Update fabric API dependency to new id (fabric-api instead of old fabric)

Additions:

  • Add option to display item durability as a gradient between green and red instead of discrete colors
  • Changed percent option from boolean to integer threshold, allowing showing percent at high durability and absolute value at low durability (useful for tools to see exact number of uses left)

Bump version to 1.11.0

Build: https://github.com/TheMrEngMan/DurabilityViewer/releases/tag/1.11.0

Fixed cardinal-components-entity causing crash due to outdated version
Bump version to 1.10.6
@TheMrEngMan TheMrEngMan mentioned this pull request Sep 29, 2023
… red instead of discrete colors

Changed percent option from boolean to integer threshold, allowing showing percent at high durability and absolute value at low durability
Bump version to 1.11.0
@TheMrEngMan TheMrEngMan changed the title Hotfix for version 1.10.5 Hotfix for version 1.10.5 + additional config options Oct 5, 2023
@Poopooracoocoo
Copy link

Poopooracoocoo commented Oct 5, 2023

Would you also please update the FMJ to depend on fabric-api instead of fabric?

It's a legacy thing that Fabric API only keeps for backwards compat. The problem is that users can get confused when they see that a mod depends on fabric

@gbl
Copy link
Owner

gbl commented Oct 6, 2023

Thank you for your commits. I'm on vacation right now, so I'll review them when I'm back home, which will be around the 15th.

@Poopooracoocoo
Copy link

In my testing this has been working well :)

@TheMrEngMan
Copy link
Contributor Author

Thank you for your commits. I'm on vacation right now, so I'll review them when I'm back home, which will be around the 15th.

@gbl reminder :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

crash on 1.20.2
3 participants