Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reverse_1bit RGBGFX test #1555

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Add reverse_1bit RGBGFX test #1555

merged 2 commits into from
Nov 25, 2024

Conversation

Rangi42
Copy link
Contributor

@Rangi42 Rangi42 commented Oct 28, 2024 •
edited
Loading

Follow-up to #1553. Adds a test for -r/--reverse with -d/--depth 1 support, which is breaking inconsistently somehow on different platforms.

reverse_1bit.1bpp result.2bpp differ: byte 9, line 1
00:0000 
< 00:0000: 0718 2040 4c8c 8c80 8080 8946 4020 1807  .. @L......F@ ..
---
00:0000 
> 00:0000: 0718 2040 4c8c 8c80 e018 0402 3231 3101  .. @L.......211.
> 00:0010: 8080 8946 4020 1807 0101 9162 0204 18e0  ...F@ .....b....

This is the original PNG image:
image

@Rangi42 Rangi42 added tests This affects the test suite rgbgfx This affects RGBGFX bug Unexpected behavior / crashes; to be fixed ASAP! labels Oct 28, 2024
@Rangi42 Rangi42 changed the title Add more RGBGFX tests Add reverse_1bit RGBGFX test Oct 28, 2024
@Rangi42 Rangi42 added this to the v0.9.0 milestone Nov 1, 2024
@Rangi42 Rangi42 mentioned this pull request Nov 3, 2024
Closed
2 tasks
@ISSOtm
Always use 2bpp TileData within RGBGFX
78d7181 
As the comment mentions, this massively improves the ability
to reason upon how the code works.
(It is, however, not super amenable to 4bpp support.
But we will cross that bridge when we get there.)
@Rangi42
Copy link
Contributor Author

Rangi42 commented Nov 25, 2024

@ISSOtm Thank you very much! 🥳

@Rangi42 Rangi42 merged commit e0ee9dc into gbdev:master Nov 25, 2024
22 checks passed
@Rangi42 Rangi42 deleted the more-gfx-tests branch November 25, 2024 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ISSOtm ISSOtm

@Rangi42 Rangi42

Labels
bug Unexpected behavior / crashes; to be fixed ASAP! rgbgfx This affects RGBGFX tests This affects the test suite
Projects
None yet
Milestone
v0.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Rangi42 @ISSOtm