Suggestions for #1294 #1314
Merged
Suggestions for #1294 #1314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Addisu Z. Taddese <[email protected]>
9 tasks
Codecov Report
@@ Coverage Diff @@
## sdf_error_parser #1314 +/- ##
====================================================
+ Coverage 87.49% 87.50% +0.01%
====================================================
Files 128 128
Lines 16926 16924 -2
====================================================
Hits 14809 14809
+ Misses 2117 2115 -2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@marcoag After working on #1303, I wanted to make sure our
sdf::Errorsobjects were either the first or last argument wherever possible. This PR does that and addresses one small comment in #1294.