Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose header for GzServer #681

Open
wants to merge 3 commits into
base: ros2
Choose a base branch
from
Open

Conversation

roncapat
Copy link

@roncapat roncapat commented Jan 8, 2025

Closes #631

Summary

Currently, no header file is defined for https://github.com/gazebosim/ros_gz/blob/ros2/ros_gz_sim/src/gzserver.cpp

This means that currently there is no possibility to import the node in a custom main.cpp to be statically composed with other nodes in the same process space, but the user is forced to go with dynamic composition.

This PR exposes the class via its own header file.

CC @mjcarroll @azeey

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@roncapat roncapat requested a review from ahcorde as a code owner January 8, 2025 15:58
ros_gz_sim/include/ros_gz_sim/gzserver.hpp Outdated Show resolved Hide resolved
ros_gz_sim/include/ros_gz_sim/gzserver.hpp Outdated Show resolved Hide resolved
Signed-off-by: Patrick Roncagliolo <[email protected]>
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
@azeey azeey changed the title Expose header for GzServer (#631) Expose header for GzServer Jan 8, 2025
Copy link
Collaborator

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see this error in CI

17:19:02 /tmp/ws/src/ros_gz/ros_gz_sim/src/gzserver.cpp:23:10: fatal error: ros_gz_sim/gzserver.hpp: No such file or directory
17:19:02    23 | #include <ros_gz_sim/gzserver.hpp>

@roncapat
Copy link
Author

Fixed & rebased

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

Statically-composable gzserver
2 participants