-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shutdown explicitly while existing #623
Conversation
Signed-off-by: ChenYing Kuo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just checking, do we need to call shutdown()
before the previous return
calls as well?
Signed-off-by: ChenYing Kuo <[email protected]>
Good catch! I believe it should be. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of multiple rclcpp::shutdown()
calls, we could wrap this call inside a callback that will automatically execute once the program terminates by relying on rcpputils::make_scope_exit().
Signed-off-by: ChenYing Kuo <[email protected]>
@Yadunund Thanks for your suggestion. I didn't know the tip before. 👍 |
@azeey Do you have any clue why
|
@ros-pull-request-builder retest this please |
@evshary Yes, there was a regression in gz-common due to a change in gz-math. We've made a release of gz-common today, but it'll probably take a couple days for the change to propagate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add rcpputils
to package.xml
as <depend>
I hit send before finishing my comment 🤦🏼 We should also include the appropriate header file and update CMakeLists.txt to explcitly link the target against |
Signed-off-by: ChenYing Kuo <[email protected]>
Done. I've added the dependency and also header file / CMakefiles.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for iterating!
https://github.com/Mergifyio update |
☑️ Nothing to do
|
https://github.com/Mergifyio backport jazzy |
✅ Backports have been created
|
Signed-off-by: ChenYing Kuo <[email protected]> (cherry picked from commit 550ef7b)
Signed-off-by: ChenYing Kuo <[email protected]> (cherry picked from commit 550ef7b) Co-authored-by: ChenYing Kuo (CY) <[email protected]>
🦟 Bug fix
Summary
Shutdown explicitly after creating an entity.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.