Add expectations to subprocess test

This adds expectations to the subprocess test instead of just checking that cout/cerr are not empty. It also adds streaming of variable values if expectations fail. Signed-off-by: Steve Peters <[email protected]>
gazebosim · Oct 14, 2024 · 4ac8e00 · 4ac8e00
1 parent 2aa20d7
commit 4ac8e00
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/test/integration/subprocess_TEST.cc b/test/integration/subprocess_TEST.cc
@@ -52,8 +52,8 @@ TEST(Subprocess, CreateInvalidSpaces)
   auto cout = proc.Stdout();
   auto cerr = proc.Stdout();
 
-  EXPECT_TRUE(cout.empty());
-  EXPECT_TRUE(cerr.empty());
+  EXPECT_TRUE(cout.empty()) << cout;
+  EXPECT_TRUE(cerr.empty()) << cerr;
 }
 
 /////////////////////////////////////////////////
@@ -71,7 +71,7 @@ TEST(Subprocess, CreateValid)
   auto cerr = proc.Stdout();
 
   EXPECT_FALSE(cout.empty());
-  EXPECT_TRUE(cerr.empty());
+  EXPECT_TRUE(cerr.empty()) << cerr;
 }
 
 /////////////////////////////////////////////////
@@ -91,7 +91,8 @@ TEST(Subprocess, Cout)
   auto cout = proc.Stdout();
   auto cerr = proc.Stderr();
   EXPECT_FALSE(cout.empty());
-  EXPECT_TRUE(cerr.empty());
+  EXPECT_NE(std::string::npos, cout.find("Iteration: ")) << cout;
+  EXPECT_TRUE(cerr.empty()) << cerr;
 }
 
 /////////////////////////////////////////////////
@@ -110,8 +111,9 @@ TEST(Subprocess, Cerr)
   EXPECT_FALSE(proc.Alive());
   auto cout = proc.Stdout();
   auto cerr = proc.Stderr();
-  EXPECT_TRUE(cout.empty());
+  EXPECT_TRUE(cout.empty()) << cout;
   EXPECT_FALSE(cerr.empty());
+  EXPECT_NE(std::string::npos, cerr.find("Iteration: ")) << cerr;
 }
 
 /////////////////////////////////////////////////