Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge gz-sim9 ➡️ main #2680

Merged
merged 5 commits into from
Nov 18, 2024
Merged

Merge gz-sim9 ➡️ main #2680

merged 5 commits into from
Nov 18, 2024

Conversation

scpeters
Copy link
Member

➡️ Forward port

Port gz-sim9 ➡️ main

Branch comparison: main...gz-sim9

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

@scpeters
Copy link
Member Author

any ideas about this test failure?

https://build.osrfoundation.org/job/gz_sim-ci-pr_any-noble-amd64/293/testReport/junit/(root)/ResetFixture/HandleReset_2/

/home/jenkins/workspace/gz_sim-ci-pr_any-noble-amd64/gz-sim/test/integration/reset_sensors.cc:260
Expected equality of these values:
  kEndingPressure
    Which is: 100362.99
  pressureReceiver.Last().pressure()
    Which is: 100360.66

it's disabled on macOS, and I believe it didn't run in the GitHub workflow due to lack of a screen

I'm going to retry the Ubuntu build to see if the test failure repeats or flakes

@iche033
Copy link
Contributor

iche033 commented Nov 18, 2024

any ideas about this test failure?

https://build.osrfoundation.org/job/gz_sim-ci-pr_any-noble-amd64/293/testReport/junit/(root)/ResetFixture/HandleReset_2/

I think I've seen that test fail before. Maybe flaky

@scpeters
Copy link
Member Author

any ideas about this test failure?
https://build.osrfoundation.org/job/gz_sim-ci-pr_any-noble-amd64/293/testReport/junit/(root)/ResetFixture/HandleReset_2/

I think I've seen that test fail before. Maybe flaky

yeah, it passed on the next run, and a different flaky test failed:

I'll merge since these are flaky tests

@scpeters scpeters merged commit 795199b into main Nov 18, 2024
9 of 10 checks passed
@scpeters scpeters deleted the scpeters/merge_9_main branch November 18, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants