Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Address light properties issue in sim::Light #2532 #2660

Open
wants to merge 1 commit into
base: gz-sim9
Choose a base branch
from

Conversation

shr-eyas
Copy link

@shr-eyas shr-eyas commented Oct 30, 2024

🦟 Bug fix

Fixes #2532

Summary

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@shr-eyas shr-eyas requested a review from mjcarroll as a code owner October 30, 2024 21:25
@github-actions github-actions bot added the 🏛️ ionic Gazebo Ionic label Oct 30, 2024
Copy link
Contributor

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks for the contribution. Would you mind applying the same logic to all the other setters as well?

@shr-eyas
Copy link
Author

shr-eyas commented Jan 7, 2025

This looks great! Thanks for the contribution. Would you mind applying the same logic to all the other setters as well?

Thanks. Sure, @azeey! Can you please elaborate where do I make the changes?
I am an avid Gazebo user but I am really new to GitHub and opensource.

@azeey
Copy link
Contributor

azeey commented Jan 7, 2025

Thanks! I was responding to your message and realized the current approach might not work properly. Let me test this more thoroughly before you make any additional changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

Setting multiple light properties using sim::Light doesn't work properly
2 participants