Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when multicopter motor system is attached to an empty model #2653

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Oct 15, 2024

🦟 Bug fix

Fixes #2646

Summary

See instructions in #2646 for reproducing the crash.

Crash happens because the multicopter motor system is not able to find the parent link name component of a joint but still tries to access the component data. Fixed by adding a check for null component.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <[email protected]>
@ahcorde ahcorde enabled auto-merge (squash) October 16, 2024 07:49
@iche033 iche033 disabled auto-merge October 16, 2024 17:28
@iche033 iche033 merged commit 990f1c2 into gz-sim9 Oct 16, 2024
9 of 11 checks passed
@iche033 iche033 deleted the multicopter_crash branch October 16, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Crash after adding plugin MulticopterMotorModel
2 participants