Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about elevator example #2227

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Conversation

mjcarroll
Copy link
Contributor

Closes #2153

Closes #2153

Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll mjcarroll self-assigned this Nov 3, 2023
@mjcarroll mjcarroll requested a review from Voldivh November 3, 2023 19:27
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Nov 3, 2023
Copy link
Contributor

@Voldivh Voldivh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #2227 (65bcd57) into gz-sim7 (b8d1679) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 65bcd57 differs from pull request most recent head cb82449. Consider uploading reports for the commit cb82449 to get more accurate results

@@           Coverage Diff            @@
##           gz-sim7    #2227   +/-   ##
========================================
  Coverage    64.75%   64.75%           
========================================
  Files          357      357           
  Lines        29144    29144           
========================================
+ Hits         18872    18873    +1     
+ Misses       10272    10271    -1     

see 1 file with indirect coverage changes

@mjcarroll mjcarroll merged commit 45233fc into gz-sim7 Nov 3, 2023
5 checks passed
@mjcarroll mjcarroll deleted the mjcarroll/add_elevator_note branch November 3, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Elevator state is not being publish on the ground floor
3 participants