Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't merge: testing #2166 with ci_matching_branch #2170

Closed

Conversation

scpeters
Copy link
Member

Testing #2166 against gazebosim/sdformat#1325 using ci_matching_branch/* names and osrf/homebrew-simulation@4d2d61f

Server: explicitly skip auto-inertial calculation

Automatic inertial calculation may not work in
Root::Load, so explicitly configure the loader
to skip auto-inertial calculation.

Do not merge

Automatic inertial calculation may not work in
Root::Load, so explicitly configure the loader
to skip auto-inertial calculation.

Signed-off-by: Steve Peters <[email protected]>
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Sep 25, 2023
@scpeters
Copy link
Member Author

this didn't actually use gazebosim/sdformat#1325 because it used bottles instead of building from source; let me try again

@scpeters
Copy link
Member Author

@osrf-jenkins run tests please

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #2170 (aff5617) into gz-sim8 (e603694) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head aff5617 differs from pull request most recent head 0c3fb6c. Consider uploading reports for the commit 0c3fb6c to get more accurate results

@@             Coverage Diff             @@
##           gz-sim8    #2170      +/-   ##
===========================================
+ Coverage    65.47%   65.49%   +0.01%     
===========================================
  Files          323      323              
  Lines        30711    30713       +2     
===========================================
+ Hits         20108    20115       +7     
+ Misses       10603    10598       -5     
Files Coverage Δ
src/Server.cc 87.22% <100.00%> (+0.14%) ⬆️

... and 2 files with indirect coverage changes

@scpeters scpeters closed this Sep 28, 2023
@scpeters scpeters deleted the ci_matching_branch/save_auto_inertia_by_default branch September 28, 2023 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant