Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport reset button fix #2159

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Backport reset button fix #2159

merged 2 commits into from
Sep 20, 2023

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Sep 20, 2023

🦟 Bug fix

Summary

backport of #2151 (a52d50c), and updated more world sdf files that were missed (28efddc).

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🌱 garden Ignition Garden label Sep 20, 2023
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #2159 (e48d12b) into gz-sim7 (9d79b62) will increase coverage by 0.01%.
Report is 1 commits behind head on gz-sim7.
The diff coverage is n/a.

❗ Current head e48d12b differs from pull request most recent head 28efddc. Consider uploading reports for the commit 28efddc to get more accurate results

@@             Coverage Diff             @@
##           gz-sim7    #2159      +/-   ##
===========================================
+ Coverage    65.01%   65.02%   +0.01%     
===========================================
  Files          356      356              
  Lines        28932    28932              
===========================================
+ Hits         18809    18812       +3     
+ Misses       10123    10120       -3     

see 3 files with indirect coverage changes

@mjcarroll mjcarroll merged commit e007fa2 into gz-sim7 Sep 20, 2023
@mjcarroll mjcarroll deleted the backport_reset_button_fix branch September 20, 2023 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants