Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example output in python tutorial #2157

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Sep 20, 2023

🦟 Bug fix

Fixes gazebosim/gazebo_test_cases#351

Summary

Matches the output with what I and @mjcarroll observed in our tests.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Addisu Z. Taddese <[email protected]>
@azeey azeey requested a review from mabelzhang as a code owner September 20, 2023 16:59
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Sep 20, 2023
@azeey azeey added the beta Targeting beta release of upcoming collection label Sep 20, 2023
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #2157 (de5cf51) into gz-sim8 (509d01a) will increase coverage by 0.01%.
Report is 1 commits behind head on gz-sim8.
The diff coverage is n/a.

❗ Current head de5cf51 differs from pull request most recent head e9e100e. Consider uploading reports for the commit e9e100e to get more accurate results

@@             Coverage Diff             @@
##           gz-sim8    #2157      +/-   ##
===========================================
+ Coverage    65.45%   65.47%   +0.01%     
===========================================
  Files          323      323              
  Lines        30708    30708              
===========================================
+ Hits         20100    20106       +6     
+ Misses       10608    10602       -6     

see 1 file with indirect coverage changes

@mjcarroll mjcarroll merged commit f55212e into gazebosim:gz-sim8 Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection 🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants