Fix bug where iterator was used after the underlying item was erased …

…from the container (#2412) Signed-off-by: Addisu Z. Taddese <[email protected]>
gazebosim · May 24, 2024 · 07e5d9c · 07e5d9c
1 parent a3e9f8d
commit 07e5d9c
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/systems/physics/EntityFeatureMap.hh b/src/systems/physics/EntityFeatureMap.hh
@@ -226,8 +226,8 @@ namespace systems::physics_system
       if (it != this->entityMap.end())
       {
         this->reverseMap.erase(it->second);
-        this->entityMap.erase(it);
         this->castCache.erase(_entity);
+        this->entityMap.erase(it);
         return true;
       }
       return false;
@@ -242,8 +242,8 @@ namespace systems::physics_system
       if (it != this->reverseMap.end())
       {
         this->entityMap.erase(it->second);
-        this->reverseMap.erase(it);
         this->castCache.erase(it->second);
+        this->reverseMap.erase(it);
         return true;
       }
       return false;