Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update examples to use metal as default graphics API on mac #937

Merged
merged 3 commits into from
Nov 1, 2023

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Oct 30, 2023

🦟 Bug fix

#914

Summary

Use metal as default graphics API on macOs

A couple of other minor fixes:

  • Fix simple_demo_qml deprecation warnings
  • stop loading optix engine as one of the default engines

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🌱 garden Ignition Garden label Oct 30, 2023
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #937 (c91ace5) into gz-rendering7 (adb0f1c) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

❗ Current head c91ace5 differs from pull request most recent head 522e36c. Consider uploading reports for the commit 522e36c to get more accurate results

@@                Coverage Diff                @@
##           gz-rendering7     #937      +/-   ##
=================================================
- Coverage          77.63%   77.62%   -0.02%     
=================================================
  Files                170      170              
  Lines              14724    14726       +2     
=================================================
  Hits               11431    11431              
- Misses              3293     3295       +2     
Files Coverage Δ
src/Utils.cc 62.68% <0.00%> (-0.95%) ⬇️

@iche033 iche033 merged commit 451e34e into gz-rendering7 Nov 1, 2023
6 of 8 checks passed
@iche033 iche033 deleted the update_examples branch November 1, 2023 18:38
@LKFierz LKFierz mentioned this pull request Feb 14, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants