Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gazebo scene viewer example #915

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Sep 20, 2023

🦟 Bug fix

gazebosim/gazebo_test_cases#693

Summary

Remove example as it no longer runs. Gazebo-classic (gazebo11) depends on different versions of gz that causes issues at run time. It also does not work on macOS.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Sep 20, 2023
Signed-off-by: Ian Chen <[email protected]>
@azeey azeey added the beta Targeting beta release of upcoming collection label Sep 20, 2023
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #915 (3e2dabb) into gz-rendering8 (5655566) will not change coverage.
The diff coverage is n/a.

❗ Current head 3e2dabb differs from pull request most recent head f92e21c. Consider uploading reports for the commit f92e21c to get more accurate results

@@              Coverage Diff               @@
##           gz-rendering8     #915   +/-   ##
==============================================
  Coverage          75.16%   75.16%           
==============================================
  Files                177      177           
  Lines              16849    16849           
==============================================
  Hits               12665    12665           
  Misses              4184     4184           

@iche033 iche033 merged commit 4190ff6 into gz-rendering8 Sep 20, 2023
6 checks passed
@iche033 iche033 deleted the remove_gazebo_scene_viewer branch September 20, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection 🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants