Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better approach to use std::variant (backport #1093) #1094

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Dec 18, 2024

🦟 Bug fix

Fixes #

Summary

Using exception for a flow control is not a very good approach in a different points of view, like from a code structure, from a performance perspective (https://godbolt.org/z/s883vGr9f)
I'd propose to use std::holds_alternative as a more simple way to improve this part of code.
Also improved some typos

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.


This is an automatic backport of pull request #1093 done by [Mergify](https://mergify.com).

* Better approach to use std::variant

Signed-off-by: Maksim Derbasov <[email protected]>

* Iteration

Signed-off-by: Maksim Derbasov <[email protected]>

---------

Signed-off-by: Maksim Derbasov <[email protected]>
(cherry picked from commit 7765666)
@mergify mergify bot requested a review from iche033 as a code owner December 18, 2024 17:26
@mergify mergify bot mentioned this pull request Dec 18, 2024
8 tasks
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Dec 18, 2024
@iche033 iche033 merged commit 6d02c15 into gz-rendering8 Dec 19, 2024
9 of 10 checks passed
@iche033 iche033 deleted the mergify/bp/gz-rendering8/pr-1093 branch December 19, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants