Fix configuration with GZ_ENABLE_RELOCATABLE_INSTALL=ON #1071
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
When
GZ_ENABLE_RELOCATABLE_INSTALL
isON
, the project that usesgz_add_get_install_prefix_impl
needs to callgz_find_package(DL REQUIRED)
. For some reason, this was not added in https://github.com/gazebosim/gz-rendering/pull/804/files, but everything was working fine for some reason. However, I tried to ocmpile gz-rendering9 on conda-forge, and know the build is failing with:See conda-forge/gz-rendering-feedstock#30 (comment) . I guess this PR should fix this problem.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.