Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7 ➡️ 8 Fix waves 'double' to 'float' truncation warning #1066

Merged
merged 3 commits into from
Sep 18, 2024

Conversation

Crola1702
Copy link
Contributor

@Crola1702 Crola1702 commented Sep 16, 2024

🦟 Bug fix

Fixes #osrf/buildfarm-tools#92 (comment)

Summary

Reference builds:

Warning:

Log output:

  waves.cc

C:\J\workspace\gz_rendering-7-win\ws\gz-rendering\test\integration\waves.cc(170,29): warning C4305: 'initializing': truncation from 'double' to 'float' [C:\J\workspace\gz_rendering-7-win\ws\build\gz-rendering7\test\integration\INTEGRATION_waves.vcxproj]

C:\J\workspace\gz_rendering-7-win\ws\gz-rendering\test\integration\waves.cc(174,28): warning C4305: 'initializing': truncation from 'double' to 'float' [C:\J\workspace\gz_rendering-7-win\ws\build\gz-rendering7\test\integration\INTEGRATION_waves.vcxproj]

  waves.obj : MSIL .netmodule or module compiled with /GL found; restarting link with /LTCG; add /LTCG to the link command line to improve linker performance

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@Crola1702 Crola1702 self-assigned this Sep 16, 2024
@Crola1702 Crola1702 requested a review from iche033 as a code owner September 16, 2024 21:02
@Crola1702 Crola1702 changed the base branch from gz-rendering9 to gz-rendering8 September 16, 2024 21:02
@github-actions github-actions bot added the 🏛️ ionic Gazebo Ionic label Sep 16, 2024
@Crola1702 Crola1702 force-pushed the Crola1702/7_to_8-16_09_2024 branch from 1720b30 to 988de19 Compare September 16, 2024 21:25
@ahcorde ahcorde enabled auto-merge (squash) September 17, 2024 09:38
@ahcorde
Copy link
Contributor

ahcorde commented Sep 17, 2024

@osrf-jenkins run tests please!

@iche033 iche033 disabled auto-merge September 18, 2024 17:11
@iche033 iche033 merged commit e227df6 into gz-rendering8 Sep 18, 2024
8 of 9 checks passed
@iche033 iche033 deleted the Crola1702/7_to_8-16_09_2024 branch September 18, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants