Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix using lightmap and emissive map together #1047

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Aug 30, 2024

🦟 Bug fix

Summary

To be used by the Ionic demo world.

Currently lightmap is applied through the emissive map slot. This means you can't use emissive map together with lightmap (only one of them can be applied). This was done to workaround an unwanted red hightlight issue found in gz-rendering6 + ogre2.2. This issue seems to be fixed now (as of gz-rendering9 + ogre 2.3). So I restored back to the original way of applying lightmaps through the detail map slot and I don't see the red highlights. Here's a screenshot of the lightmap sdf world with this change:

lightmap_as_detailmap

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🏛️ ionic Gazebo Ionic label Aug 30, 2024
@iche033 iche033 merged commit 6ec0c52 into gz-rendering9 Sep 5, 2024
9 of 11 checks passed
@iche033 iche033 deleted the emissivemap_lightmap branch September 5, 2024 17:59
iche033 added a commit that referenced this pull request Sep 17, 2024
iche033 added a commit that referenced this pull request Sep 18, 2024
Revert "Fix using lightmap and emissive map together (#1047)"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants