Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Roboto fonts to ogre plugin #1035

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

qingyouzhao
Copy link
Contributor

@qingyouzhao qingyouzhao commented Aug 13, 2024

🎉 New feature

Closes #512

Summary

Installs Roboto downloaded from https://fonts.google.com/specimen/Roboto/about

Test it

Added tests to Text_TEST.cc

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@qingyouzhao qingyouzhao requested a review from iche033 as a code owner August 13, 2024 06:07
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Aug 13, 2024
@iche033
Copy link
Contributor

iche033 commented Aug 13, 2024

looks good to me, tested with the text_geom example:

text_geom_roboto

@iche033 iche033 merged commit 64820c0 into gazebosim:gz-rendering8 Aug 13, 2024
8 of 9 checks passed
Crola1702 pushed a commit that referenced this pull request Sep 16, 2024
Signed-off-by: __zqy__ <[email protected]>
Signed-off-by: Crola1702 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Allow using Roboto font on Text geometries
2 participants