Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add include <chrono> for system_clock #655

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

WangWeiLin-MV
Copy link

🦟 Bug fix

No bug number.

Summary

An issue revealed in microsoft/STL#5105, that can be fixed by including <chrono>.

include\gz\common5\gz/common/Event.hh(89): error C2039: 'system_clock': is not a member of 'std::chrono'

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: WangWeiLin-MV <[email protected]>
@ahcorde
Copy link
Contributor

ahcorde commented Dec 12, 2024

The PR is still a draft, do you more changes to include ? otherwise you can change the status to "Ready fo review".

change looks good to me

@WangWeiLin-MV WangWeiLin-MV marked this pull request as ready for review December 12, 2024 09:09
@ahcorde ahcorde enabled auto-merge (squash) December 13, 2024 21:42
@iche033
Copy link
Contributor

iche033 commented Dec 14, 2024

@osrf-jenkins run tests please

@iche033 iche033 disabled auto-merge December 17, 2024 18:23
@iche033 iche033 merged commit b094746 into gazebosim:gz-common5 Dec 17, 2024
11 checks passed
@WangWeiLin-MV WangWeiLin-MV deleted the events/add-include-chrono branch December 23, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants