-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deprecation warnings #603
Conversation
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
@@ -67,7 +67,7 @@ void AudioDecoder::Cleanup() | |||
{ | |||
// Close the codec | |||
if (this->data->codecCtx) | |||
avcodec_close(this->data->codecCtx); | |||
avcodec_free_context(&this->data->codecCtx); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this change causes a test failure on 20.04; perhaps we can ifdef
on the software version if we can figure out the difference in the version variables between 20.04 and 22.04?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't do much investigation into whether we can simply replace avcodec_close
with avcodec_free_context
, but let me try it on a newer version of Ubuntu to see if it fails everywhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Addisu Z. Taddese <[email protected]>
🦟 Bug fix
Summary
Fix deprecation warnings:
avcodec_close
withavcodec_free_context
std::iterator
since we can't change it without breaking ABI. I only did this for macOS, since that's the only platform that emits the warning.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.