Add new function in MeshManager to merge all submeshes of a mesh into one #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <[email protected]>
iche033
commented
Mar 26, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #588 +/- ##
==========================================
+ Coverage 80.47% 80.54% +0.06%
==========================================
Files 80 80
Lines 13542 13573 +31
==========================================
+ Hits 10898 10932 +34
+ Misses 2644 2641 -3 ☔ View full report in Codecov by Sentry. |
ahcorde
approved these changes
Mar 26, 2024
Signed-off-by: Ian Chen <[email protected]>
9 tasks
iche033
added a commit
that referenced
this pull request
Apr 8, 2024
… one (#588) --------- Signed-off-by: Ian Chen <[email protected]>
iche033
added a commit
that referenced
this pull request
Apr 8, 2024
… one (#588) --------- Signed-off-by: Ian Chen <[email protected]>
mjcarroll
added a commit
that referenced
this pull request
Apr 11, 2024
* Various Bazel adjustments for linting (#582) Signed-off-by: Michael Carroll <[email protected]> * Prepare for 5.5.1 (#586) Signed-off-by: Addisu Z. Taddese <[email protected]> * Adds new function in MeshManager for performing convex decomposition (#585) Signed-off-by: Ian Chen <[email protected]> * Add new function in MeshManager to merge all submeshes of a mesh into one (#588) --------- Signed-off-by: Ian Chen <[email protected]> * Fix bazel build (#592) Signed-off-by: Shameek Ganguly <[email protected]> * Remove pessimizing move (#593) Signed-off-by: Shameek Ganguly <[email protected]> Signed-off-by: Michael Carroll <[email protected]> Co-authored-by: Shameek Ganguly <[email protected]> --------- Signed-off-by: Michael Carroll <[email protected]> Signed-off-by: Addisu Z. Taddese <[email protected]> Signed-off-by: Ian Chen <[email protected]> Signed-off-by: Shameek Ganguly <[email protected]> Co-authored-by: Addisu Z. Taddese <[email protected]> Co-authored-by: Ian Chen <[email protected]> Co-authored-by: shameekganguly <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Summary
Add a new static function in MeshManager to merge all submeshes into one. The new function returns a new mesh with a single combined submesh
Note I also made the
ConvexDecompositionfunction that I added in #585 static as it does not need to be a member function.Test it
Added a test that merges two submehes and checked that all its vertices, normals, indices, and texcoords are correct.
Run the
UNIT_MeshManager_TESTChecklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.