Fix segfault in case of no write access to log dir #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 25, 2023 11:05
If there is no permission to create the log directories, the FileLogger will call itself recutsive, as is used ignerr for logging the error, which will call FileLogger::Init again. This commit fixed this, by using std::cerr for the log output in FileLogger::Init. Signed-off-by: Janosch Machowinski <[email protected]>
Signed-off-by: Janosch Machowinski <[email protected]>
jmachowinski
changed the title
once merged, this will be forward ported across versions. |
iche033
reviewed
Oct 26, 2023
Co-authored-by: Ian Chen <[email protected]> Signed-off-by: jmachowinski <[email protected]>
Co-authored-by: Ian Chen <[email protected]> Signed-off-by: jmachowinski <[email protected]>
|
ping ? |
mjcarroll
reviewed
Nov 13, 2023
| @@ -41,7 +41,7 @@ IGN_ENUM(myTypeIface, MyType, MY_TYPE_BEGIN, MY_TYPE_END, | |||
| ///////////////////////////////////////////////// | |||
| TEST_F(EnumIfaceTest, StringCoversion) | |||
| { | |||
| MyType type; | |||
| MyType type = MyType::TYPE2; | |||
There was a problem hiding this comment.
Is this change related to the rest of the pull request?
There was a problem hiding this comment.
No, this is a separate commit fixing a compile warning.
mjcarroll
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes a Segfault when building Ign common3 with pbuilder
Summary
If there is no write access to the log directory, the logger will call itself recusively in an infinite loop and segfault.
Note, this bug is also present in the latest version of ign common.