Added BVH and STL loader tests #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ahcorde <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-common3 #466 +/- ##
===============================================
+ Coverage 78.91% 81.65% +2.73%
===============================================
Files 72 72
Lines 9244 9244
===============================================
+ Hits 7295 7548 +253
+ Misses 1949 1696 -253
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
ahcorde
force-pushed
the
ahcorde/3/coverage_loaders
branch
from
554dc45 to
071278d
Compare
Signed-off-by: ahcorde <[email protected]>
|
New segfault on Windows. |
Signed-off-by: ahcorde <[email protected]>
|
Signed-off-by: ahcorde <[email protected]>
|
Hmm, segfault on |
Signed-off-by: ahcorde <[email protected]>
Moved MeshCSG test to this other PR #469 |
mjcarroll
approved these changes
Oct 26, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ahcorde [email protected]
🎉 New feature
Closes #
Summary
Added BVH and STL loader tests
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.