Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds dummy animation for the root scene node #429

Closed
wants to merge 6 commits into from

Conversation

onurtore
Copy link
Contributor

@onurtore onurtore commented Aug 22, 2022

🦟 Bug fix

Fixes #393

Summary

Adds dummy animation for the root scene.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Onur Berk Tore added 2 commits August 22, 2022 15:05
Signed-off-by: Onur Berk Tore <[email protected]>
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Aug 22, 2022
@chapulina chapulina added the bug Something isn't working label Aug 26, 2022
@onurtore onurtore marked this pull request as ready for review September 29, 2022 15:39
@onurtore onurtore requested a review from mjcarroll as a code owner September 29, 2022 15:39
@azeey azeey added beta Targeting beta release of upcoming collection and removed beta Targeting beta release of upcoming collection labels Jul 31, 2023
@onurtore onurtore requested a review from marcoag as a code owner January 5, 2024 17:25
@azeey azeey added the beta Targeting beta release of upcoming collection label Jul 29, 2024
@azeey
Copy link
Contributor

azeey commented Jul 29, 2024

@luca-della-vedova would you be able to give this a look?

@luca-della-vedova
Copy link
Member

I can't remember the exact details of this PR but iirc it was to fix a corner case when parsing one specific collada actor with the Assimp loader, which in the end is also hidden behind a custom environment variable, we can revisit these corner cases if we were to remove our custom parser and just use assimp for every mesh, otherwise this is extremely niche and not sure about the implications on other models

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection bug Something isn't working 🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants