Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that find_package(TinyXML2) defines tinyxml2::tinyxml2 even on case insensitive filesystems #465

Open
wants to merge 1 commit into
base: gz-cmake4
Choose a base branch
from

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Jan 23, 2025

🦟 Bug fix

Summary

On case-insensitive filesystem, it is possible that FindTinyXML2.cmake is used if the caller invoked find_package(TINYXML2), that is the signature used by tinyxml2_vendor, see https://github.com/ros2/tinyxml2_vendor/blob/b66cece6ed99ba3c3b2b64bc56c0f717dd33243b/cmake/Modules/FindTinyXML2.cmake .

If that is the case (and we detect it by checking the value of CMAKE_FIND_PACKAGE_NAME) we also define a tinyxml2::tinyxml2 target for tinyxml2_vendor compatibility.

This is a sister PR of ros2/tinyxml2_vendor#22 .

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

… case insensitive filesystems

Signed-off-by: Silvio Traversaro <[email protected]>
@github-actions github-actions bot added 🏛️ ionic Gazebo Ionic 🪵 jetty Gazebo Jetty labels Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic 🪵 jetty Gazebo Jetty
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

1 participant