Ensure that find_package(TinyXML2) defines tinyxml2::tinyxml2 even on case insensitive filesystems #465
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
On case-insensitive filesystem, it is possible that FindTinyXML2.cmake is used if the caller invoked find_package(TINYXML2), that is the signature used by tinyxml2_vendor, see https://github.com/ros2/tinyxml2_vendor/blob/b66cece6ed99ba3c3b2b64bc56c0f717dd33243b/cmake/Modules/FindTinyXML2.cmake .
If that is the case (and we detect it by checking the value of CMAKE_FIND_PACKAGE_NAME) we also define a tinyxml2::tinyxml2 target for tinyxml2_vendor compatibility.
This is a sister PR of ros2/tinyxml2_vendor#22 .
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.