-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added husky and lint #9
Conversation
Signed-off-by: Saurabh Kamat <[email protected]>
Signed-off-by: Saurabh Kamat <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks right to me. However we need a way to run the linter on PR changes to be sure that we are complaining with it? Is it being run somewhere now in our workflow? If not, maybe adding something like https://github.com/ros-tooling/setup-ros/blob/master/.github/workflows/pr.yml can help to check that the linter is in action.
Signed-off-by: Saurabh Kamat <[email protected]>
Signed-off-by: Saurabh Kamat <[email protected]>
Signed-off-by: Saurabh Kamat <[email protected]>
Signed-off-by: Saurabh Kamat <[email protected]>
Great idea! Added a workflow to check PRs. All checks pass 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful !
Closes #8.
Closes #6.
Summary
setup-ros
, added lint-staged to run through husky pre-commit.package.json
.