Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added husky and lint #9

Merged
merged 6 commits into from
Jun 6, 2024
Merged

Conversation

sauk2
Copy link
Collaborator

@sauk2 sauk2 commented Jun 5, 2024

Closes #8.
Closes #6.

Summary

  • Taking reference from setup-ros, added lint-staged to run through husky pre-commit.
  • Added run instructions for lint in package.json.
  • Added a workflow to check PRs.

@sauk2 sauk2 requested a review from j-rivero June 5, 2024 16:29
Copy link
Contributor

@j-rivero j-rivero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks right to me. However we need a way to run the linter on PR changes to be sure that we are complaining with it? Is it being run somewhere now in our workflow? If not, maybe adding something like https://github.com/ros-tooling/setup-ros/blob/master/.github/workflows/pr.yml can help to check that the linter is in action.

sauk2 added 4 commits June 6, 2024 20:44
Signed-off-by: Saurabh Kamat <[email protected]>
Signed-off-by: Saurabh Kamat <[email protected]>
@sauk2
Copy link
Collaborator Author

sauk2 commented Jun 6, 2024

Changes looks right to me. However we need a way to run the linter on PR changes to be sure that we are complaining with it? Is it being run somewhere now in our workflow? If not, maybe adding something like https://github.com/ros-tooling/setup-ros/blob/master/.github/workflows/pr.yml can help to check that the linter is in action.

Great idea! Added a workflow to check PRs. All checks pass 🎉

@sauk2 sauk2 requested a review from j-rivero June 6, 2024 12:53
Copy link
Contributor

@j-rivero j-rivero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful !

@j-rivero j-rivero merged commit d26e0c5 into gazebo-tooling:main Jun 6, 2024
5 checks passed
@sauk2 sauk2 deleted the feat/husky-integration branch June 6, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add husky to rebuild action on every commit Add workflow to check PRs
2 participants