Action to setup up Ubuntu inside a docker container #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Saurabh Kamat <[email protected]>
Signed-off-by: Saurabh Kamat <[email protected]>
Signed-off-by: Saurabh Kamat <[email protected]>
Signed-off-by: Saurabh Kamat <[email protected]>
Signed-off-by: Saurabh Kamat <[email protected]>
j-rivero
approved these changes
Jun 3, 2024
There was a problem hiding this comment.
This is a great start 🚀
I can not see any problem in the code and my local build also works just fine. I miss a bit of the README that probably will fits better later and the linters and other configs that the setup-ros uses and could be nice to have. That can go in other PRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR sets up Ubuntu inside a docker container by installing essential packages and performing some os configurations. It also sets up a workflow to test this action. This action is set to run on a
workflow_dispatchtrigger.Workflows are not visible in the GitHub Actions tab unless they are present in
main. This can act as an intermediate to PR #3, which contains an implementation of the action described in Issue #1.Once this gets merged, we will be able to test the action in PR #3 by running the workflow for a specific branch.