Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for prerelease and nightly repos #20

Merged
merged 10 commits into from
Jun 18, 2024

Conversation

sauk2
Copy link
Collaborator

@sauk2 sauk2 commented Jun 15, 2024

Closes #17

Summary

This PR adds support to ubuntu-prerelease and ubuntu-nightly Gazebo repositories.

Two additional tests have been added to the workflow to test the installation of harmonic on jammy and noble using the unstable repos.

@sauk2 sauk2 requested a review from j-rivero June 15, 2024 10:31
Copy link
Contributor

@j-rivero j-rivero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Both prelease and nighly can be installed together, both requires to have gazebo-stable but all three can be working perfectly. Let's change the code so we can use that option.

In the PR we also need documenttion in the README about how to use these options.

dist/index.js Outdated Show resolved Hide resolved
@sauk2 sauk2 requested a review from j-rivero June 17, 2024 17:49
@sauk2
Copy link
Collaborator Author

sauk2 commented Jun 17, 2024

Thanks for the PR!

Both prelease and nighly can be installed together, both requires to have gazebo-stable but all three can be working perfectly. Let's change the code so we can use that option.

In the PR we also need documenttion in the README about how to use these options.

Updated the function to allow both the nightly and prerelease together. All checks pass. Will be adding tests and updating README!

@sauk2
Copy link
Collaborator Author

sauk2 commented Jun 18, 2024

@j-rivero Added unit tests and updated README with instructions. All checks pass!

@sauk2 sauk2 requested a review from j-rivero June 18, 2024 14:25
Copy link
Contributor

@j-rivero j-rivero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minimal suggestion to document the problem on Noble. Good to go. Great work !

@j-rivero j-rivero merged commit 6d7c719 into gazebo-tooling:main Jun 18, 2024
11 checks passed
@sauk2 sauk2 deleted the feat/add-unstable-repos branch June 19, 2024 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend support for Gazebo pre-release and nightly repositories
2 participants