-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for prerelease and nightly repos #20
Conversation
Signed-off-by: Saurabh Kamat <[email protected]>
Signed-off-by: Saurabh Kamat <[email protected]>
Signed-off-by: Saurabh Kamat <[email protected]>
Signed-off-by: Saurabh Kamat <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Both prelease and nighly can be installed together, both requires to have gazebo-stable but all three can be working perfectly. Let's change the code so we can use that option.
In the PR we also need documenttion in the README about how to use these options.
Signed-off-by: Saurabh Kamat <[email protected]>
Updated the function to allow both the nightly and prerelease together. All checks pass. Will be adding tests and updating README! |
Signed-off-by: Saurabh Kamat <[email protected]>
Signed-off-by: Saurabh Kamat <[email protected]>
@j-rivero Added unit tests and updated README with instructions. All checks pass! |
Signed-off-by: Saurabh Kamat <[email protected]>
Signed-off-by: Saurabh Kamat <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minimal suggestion to document the problem on Noble. Good to go. Great work !
Signed-off-by: Saurabh Kamat <[email protected]>
Closes #17
Summary
This PR adds support to
ubuntu-prerelease
andubuntu-nightly
Gazebo repositories.Two additional tests have been added to the workflow to test the installation of
harmonic
onjammy
andnoble
using the unstable repos.